Attention is currently required from: fixeria, pespin, daniel.
lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259 )
Change subject: Translate GSUP Auth Info Answer error Cause in Diamater AIA ......................................................................
Patch Set 1:
(10 comments)
Patchset:
PS1: Hi Pau, do you found the translation table in TS 29.272 Annex A rel 17? (Diameter to the NAS cause codes and Annex B for the SGSN NAS codes.)
File src/server_cb.erl:
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/3522f28a_1... PS1, Line 187: DIAMETER_ERROR_RAT_NOT_ALLOWED DIAMETER_ERROR_UNKNOWN_EPS_SUBSCRIPTION
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/37072e48_f... PS1, Line 189: gsup_cause2dia(?GMM_CAUSE_LA_NOTALLOWED) -> {[], [?EXP_RES(?DIAMETER_ERROR_RAT_NOT_ALLOWED)]}; Maybe DIAMETER_AUTHORIZATION_REJECTED would be better.
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/bea8ea79_b... PS1, Line 191: DIAMETER_ERROR_UNKOWN_SERVING_NODE DIAMETER_ERROR_UNKNOWN_EPS_SUBSCRIPTION
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/7aac8f68_c... PS1, Line 192: DIAMETER_AUTHENTICATION_DATA_UNAVAILABLE 29.272 rel 17: Annex A and Annex B can be used to translate those. IMHO: This should be unable_to_comply
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/792fb42a_e... PS1, Line 193: gsup_cause2dia(?GMM_CAUSE_CONGESTION) -> {[], [?EXP_RES(?DIAMETER_AUTHENTICATION_DATA_UNAVAILABLE)]}; I would send unable to comply here, even it is not defined.
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/bd2ed798_c... PS1, Line 194: GMM_CAUSE_GSM_AUTH_UNACCEPT I would remove this. We should never get this error and we don't use it on the hlr so far.
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/a10c784f_e... PS1, Line 195: DIAMETER_ERROR_UNKOWN_SERVING_NODE DIAMETER_MISSING_AVP
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/b994c2af_7... PS1, Line 196: DIAMETER_ERROR_UNKOWN_SERVING_NODE DIAMETER_UNABLE_TO_COMPLY
https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/85b97d0f_6... PS1, Line 197: TODO: more values
This TODO can be removed I guess?
not yet.I've a patch for this.