[S] Change in ...osmo_dia2gsup[master]: Translate GSUP Auth Info Answer error Cause in Diamater AIA

Attention is currently required from: fixeria, pespin, daniel. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259 ) Change subject: Translate GSUP Auth Info Answer error Cause in Diamater AIA ...................................................................... Patch Set 1: (10 comments) Patchset: PS1: Hi Pau, do you found the translation table in TS 29.272 Annex A rel 17? (Diameter to the NAS cause codes and Annex B for the SGSN NAS codes.) File src/server_cb.erl: https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/3522f28a_… PS1, Line 187: DIAMETER_ERROR_RAT_NOT_ALLOWED DIAMETER_ERROR_UNKNOWN_EPS_SUBSCRIPTION https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/37072e48_… PS1, Line 189: gsup_cause2dia(?GMM_CAUSE_LA_NOTALLOWED) -> {[], [?EXP_RES(?DIAMETER_ERROR_RAT_NOT_ALLOWED)]}; Maybe DIAMETER_AUTHORIZATION_REJECTED would be better. https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/bea8ea79_… PS1, Line 191: DIAMETER_ERROR_UNKOWN_SERVING_NODE DIAMETER_ERROR_UNKNOWN_EPS_SUBSCRIPTION https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/7aac8f68_… PS1, Line 192: DIAMETER_AUTHENTICATION_DATA_UNAVAILABLE 29.272 rel 17: Annex A and Annex B can be used to translate those. IMHO: This should be unable_to_comply https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/792fb42a_… PS1, Line 193: gsup_cause2dia(?GMM_CAUSE_CONGESTION) -> {[], [?EXP_RES(?DIAMETER_AUTHENTICATION_DATA_UNAVAILABLE)]}; I would send unable to comply here, even it is not defined. https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/bd2ed798_… PS1, Line 194: GMM_CAUSE_GSM_AUTH_UNACCEPT I would remove this. We should never get this error and we don't use it on the hlr so far. https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/a10c784f_… PS1, Line 195: DIAMETER_ERROR_UNKOWN_SERVING_NODE DIAMETER_MISSING_AVP https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/b994c2af_… PS1, Line 196: DIAMETER_ERROR_UNKOWN_SERVING_NODE DIAMETER_UNABLE_TO_COMPLY https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259/comment/85b97d0f_… PS1, Line 197: TODO: more values not yet.I've a patch for this. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34259 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I32622713c2c1f40e1d9c5597ffab8cb211171fc2 Gerrit-Change-Number: 34259 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Sep 2023 14:12:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment