Attention is currently required from: pespin, fixeria.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741 )
Change subject: build: fix linking gen__pfcp_ies_auto to use build-tree libosmo-gtlv ......................................................................
Patch Set 1:
(1 comment)
File src/libosmo-pfcp/Makefile.am:
https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741/comment/7f30d7fa_0347fc4c PS1, Line 68: gen__pfcp_ies_auto_LDFLAGS
this is the same fix: LDADD I presume appends libs to the AM_LDFLAGS from above. […]
erm ok, of course there is some linking phase for the library and it has LDFLAGS. What i meant is the library linking doesn't need to link the actual objects it depends on -- so the LDFLAGS for libosmo-pfcp doesn't need to link libosmocore.so or libosmogsm.so. And what i meant is the library has its own LDFLAGS directive, so it doesn't use the global AM_LDFLAGS directive.
building the library still needs the CFLAGS for the #includes from the .c/.h files.
only the gen__pfcp_... tool needs to add the actual FOO_LIBS to LDFLAGS to build the executable. so it will have its own LDFLAGS now.