Attention is currently required from: osmith, neels, laforge, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712 )
Change subject: Add subscr_conn_fsm
......................................................................
Patch Set 5:
(1 comment)
File src/osmo-bsc-nat/bssap_conn.c:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712/comment/7ada68e1_4223f2f1
PS4, Line 47: uint8_t tag = tag_order[i];
About leaving all other known and unknown IEs unchanged: I think there can theoretically also be unk […]
The best approach is probably locating the important IE start of buffer by using tlv_parse, then simply modify that IE buffer with the new content and resend the buffer as it is, no need to encode it again?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc-nat
Gerrit-Branch: master
Gerrit-Change-Id: I7e491aada6f5db0eb35ef2039869c6ba07f9ca3b
Gerrit-Change-Number: 27712
Gerrit-PatchSet: 5
Gerrit-Owner: osmith
osmith@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: neels
nhofmeyr@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: osmith
osmith@sysmocom.de
Gerrit-Attention: neels
nhofmeyr@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Wed, 08 Jun 2022 11:12:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels
nhofmeyr@sysmocom.de
Gerrit-MessageType: comment
