Attention is currently required from: laforge, pespin, fixeria.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27423 )
Change subject: ggsn: Initial testing of open5gs Gy interface
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
File ggsn_tests/GGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27423/comment/f63efc20_1b0f…
PS3, Line 2229: /* Sent some data and validate it is reported in the TERMINATION_REQUEST
(triggered by PFCP Session Deletion Response): */
very long line
File library/DIAMETER_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27423/comment/e968996f_7fc2…
PS3, Line 1226: /* FIXME: change this to use "Validity-Time" instead of
"CC-Time" */
Is the unresolved fixme here kept on purpose?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27423
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I10027d4f8adc6b47ce97b90514d1f13e9aa3d40d
Gerrit-Change-Number: 27423
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 11 Apr 2022 10:46:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment