Attention is currently required from: fixeria.
msuraev has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-sccp/+/29087 )
Change subject: SIGTRAN: add function to check connection existence
......................................................................
Patch Set 7:
(2 comments)
This change is ready for review.
File examples/sccp_test_vty.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/29087/comment/310a2908_4033cfc1
PS4, Line 48:
We usually align arguments to the opening parenthesis.
Ack
File include/osmocom/sigtran/sccp_helpers.h:
https://gerrit.osmocom.org/c/libosmo-sccp/+/29087/comment/718acf67_ce1e5dcf
PS4, Line 70: exist
'conn_id' is a singular, so I guess it should
be 'exists'?
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sccp/+/29087
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Iffedf55b4c292ee6b2f97bcdeef6dc13c050ce01
Gerrit-Change-Number: 29087
Gerrit-PatchSet: 7
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 15 Aug 2022 14:32:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment