Attention is currently required from: neels, pespin, daniel.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/30347
)
Change subject: paging: Replace reqs waiting for retransmission with new incoming inital
req if queue is full
......................................................................
Patch Set 7: Code-Review+1
(4 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-bsc/+/30347/comment/f1ad7abe_4ec1b831
PS1, Line 14: is it
.
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/30347/comment/eee93fdb_04989c7f
PS1, Line 16: than
that
Done
Commit Message:
https://gerrit.osmocom.org/c/osmo-bsc/+/30347/comment/7ac40bf1_4584e3e7
PS7, Line 22: OS
SYS
File src/osmo-bsc/net_init.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30347/comment/c0de5a73_cd6ef2d4
PS6, Line 81: random
Maybe just remove "random" here completely?
I was looking through the code to find the call to rand […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/30347
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Idfd93254ae456b1ee08416e05479488299dd063d
Gerrit-Change-Number: 30347
Gerrit-PatchSet: 7
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 13:35:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: comment