Attention is currently required from: msuraev.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28996 )
Change subject: Diversify osmo_sockaddr_str_*() error codes
......................................................................
Patch Set 5: Code-Review-1
(1 comment)
Patchset:
PS4:
Which error code would you suggest to make those different?
Is there really a need to have a separate error code for all paths? If an invalid value is passed, then return -EINVAL and not some other random not fitting code, otherwise it's misleading.
If you want to see which error code was returned, add a specific print or use a debugger.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/28996
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic1be25a076776de5b417cb5ac66f954ac5680e10
Gerrit-Change-Number: 28996
Gerrit-PatchSet: 5
Gerrit-Owner: msuraev
msuraev@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: msuraev
msuraev@sysmocom.de
Gerrit-Comment-Date: Wed, 10 Aug 2022 13:47:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Comment-In-Reply-To: msuraev
msuraev@sysmocom.de
Gerrit-MessageType: comment