Change in pysim[master]: filesystem: add unit tests for encoder/decoder methods

Attention is currently required from: fixeria, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24012 ) Change subject: filesystem: add unit tests for encoder/decoder methods ...................................................................... Patch Set 8: (4 comments) Patchset: PS8: I'm going to try to resurrect this after not receiving any updates for a very long time File tests/test_files.py: https://gerrit.osmocom.org/c/pysim/+/24012/comment/041b7790_4c538a5f PS4, Line 57: for testvec_json in ef.__class__._encode_decode_testvector: The problem without subTest is that it simply stops a the first assert and doesn't continue to check any of the other tests. https://gerrit.osmocom.org/c/pysim/+/24012/comment/e9365221_b53a4b45 PS4, Line 94: for obj in gc.get_objects(): we already have utils.py:all_subclasses() for getting that recursive list. https://gerrit.osmocom.org/c/pysim/+/24012/comment/2c85d811_e83fd3d0 PS4, Line 96: if not file_in_list(test_candidates, obj.name): Ack -- To view, visit https://gerrit.osmocom.org/c/pysim/+/24012 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I02d884547f4982e0b8ed7ef21b8cda75237942e2 Gerrit-Change-Number: 24012 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Falkenber9 <robert.falkenberg(a)tu-dortmund.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 27 Jan 2023 13:52:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment