Attention is currently required from: fixeria, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24012 )
Change subject: filesystem: add unit tests for encoder/decoder methods ......................................................................
Patch Set 8:
(4 comments)
Patchset:
PS8: I'm going to try to resurrect this after not receiving any updates for a very long time
File tests/test_files.py:
https://gerrit.osmocom.org/c/pysim/+/24012/comment/041b7790_4c538a5f PS4, Line 57: for testvec_json in ef.__class__._encode_decode_testvector:
I do not understand what you mean. […]
The problem without subTest is that it simply stops a the first assert and doesn't continue to check any of the other tests.
https://gerrit.osmocom.org/c/pysim/+/24012/comment/e9365221_b53a4b45 PS4, Line 94: for obj in gc.get_objects():
Using garbage collector for finding all instances of CardEF is an option, but how can you be sure th […]
we already have utils.py:all_subclasses() for getting that recursive list.
https://gerrit.osmocom.org/c/pysim/+/24012/comment/2c85d811_e83fd3d0 PS4, Line 96: if not file_in_list(test_candidates, obj.name):
Would be nice to implement the concept of sub-tests here for each file: […]
Ack