Attention is currently required from: neels.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-sccp/+/32321 )
Change subject: add public API: osmo_sccp_instance_next_conn_id()
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
AFAIU, when using this function instead of each's app function, you'll then be
iterating over a different data structure / subset of conns in order to find the next free
one. Are you sure this is correct? (I'm not saying it's not, I just want to make
sure this detail was thought about).
Also, see my comment regarding max_* parameter.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sccp/+/32321
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: If59d524fbe1088a59ae1b69908e2d4bf67113439
Gerrit-Change-Number: 32321
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 17 Apr 2023 09:16:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment