19 Apr
2022
19 Apr
'22
10:51 a.m.
Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27802 )
Change subject: osmo-bts-trx: move tx_tch_common() into a separate file ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Patchset:
PS1: Having such a long function static inline in a header file looks wrong to me. I see no good reason to have this merged.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27802
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id0b9d604e6969a8db73ef451fbcad00f57325fc4
Gerrit-Change-Number: 27802
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Tue, 19 Apr 2022 08:51:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment