Attention is currently required from: laforge, osmith.
fixeria has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37728?usp=email )
Change subject: Makefile: add 'install' target
......................................................................
Patch Set 3:
(1 comment)
File Makefile:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37728/comment/fb2217c9_64e2…
:
PS2, Line 36: install -m 0644 -T config/sys.config $(DESTDIR)$(CONFDIR)/osmo-s1gw.config
As in the other patch, I suggest using install -Dm644
etc. […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/37728?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: If4901adb648c98d52dbc0abd97413c20503fb278
Gerrit-Change-Number: 37728
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 05 Aug 2024 17:00:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>