Attention is currently required from: arehbein, pespin, lynxis lazus.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31199 )
Change subject: sgsn: Add TC_attach_timeout_after_pdp_act ......................................................................
Patch Set 2:
(1 comment)
File sgsn/SGSN_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31199/comment/b43197b5_a18c5... PS1, Line 1037: attach_req.msgs.gprs_mm.attachRequest.msNetworkCapability.msNetworkCapabilityV.revisionLevelIndicatior := '1'B;
As stated in the comment, if you look at f_gmm_attach(), there are comments concerning these lines. […]
So there are two topics: * revisionLevelIndicator. That really only needs to be set to '1' if you want to tell the ntework that you're supporting Rel99-or-later, i.e. that this is a UMTS capable UE attaching over GSM. This should be irrelevanti n this context, AFAICT
* solSACapability - according to a comment in f_gmm_attach() there's an encoder problem if it's "omit". This sounds like the ts_GMM_ATTACH_REQ() should be changed to define solSACapability as '0' insteads of omit. At that point none of the users of ts_GMM_ATTACH_REQ will need to manually modify it anymore. Please submit a separate patch before this patch to clean this up, thanks!