Attention is currently required from: daniel, lynxis lazus.
laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email )
Change subject: GMM: split parsing of a RA Update Request in a separate file ......................................................................
Patch Set 21:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-sgsn/+/37869/comment/5de306bd_17c98f2c?usp... : PS21, Line 9: gprs_gmm.c is huge. Further split the general validation : and parsing of the message into an own function. : does it make sense to do this split for a single message? If we think the code should be split, shouldn't we separate all of the message parsing for all the messages in one commit?