Attention is currently required from: laforge, neels, pespin.
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539?usp=email )
Change subject: per-HNB GTP-U traffic counters via nft ......................................................................
Patch Set 5:
(5 comments)
File src/osmo-hnbgw/nft_kpi.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16223): https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/df4ad6ff_ceda3078 PS5, Line 193: static const char *nft_thread_req_type_name[] = { static const char * array should probably be static const char * const
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16223): https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/d6770d68_79f2c7f2 PS5, Line 620: while (1) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16223): https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/7508f387_d8d5a2c9 PS5, Line 652: if (period_us < 1) suspect code indent for conditional statements (7, 15)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16223): https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/3bdc932d_afd931ff PS5, Line 653: period_us = 1; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16223): https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/7901fdad_9cee6d30 PS5, Line 653: period_us = 1; please, no spaces at the start of a line