[S] Change in osmo-ggsn[master]: lib/gtp-kernel.c: initialize ret with 0

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36089?usp=email ) Change subject: lib/gtp-kernel.c: initialize ret with 0 ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-ggsn/+/36089/comment/9727b7b9_786dfd94 PS1, Line 11: /home/pespin/dev/sysmocom/git/osmo-ggsn/lib/gtp-kernel.c: In function ‘gtp_kernel_tunnel_add’: I think you can get rid of these paths :) File lib/gtp-kernel.c: https://gerrit.osmocom.org/c/osmo-ggsn/+/36089/comment/e4e99d1f_df17e878 PS1, Line 117: ms_addr_count = in46a_from_eua(&pdp->eua, ms); if in46a_from_eua returns negative, you are still returning 0. You need to do "ret = ms_addr_count;" or similar instead of ret = 0 at the start. -- To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/36089?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I19067ebe561d4c067b9ace7f5b201e15af6b342e Gerrit-Change-Number: 36089 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 27 Feb 2024 14:59:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment