dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/30725
)
Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
This patch had to be abandoned since the Change-ID appeared to be duplicated in and it was
no longer possible to push:
$ git push origin HEAD:refs/for/master%topic=gsm_hr_format --no-thin
Enumerating objects: 15, done.
Counting objects: 100% (15/15), done.
Delta compression using up to 2 threads
Compressing objects: 100% (15/15), done.
Writing objects: 100% (15/15), 28.15 KiB | 929.00 KiB/s, done.
Total 15 (delta 4), reused 0 (delta 0)
remote: Resolving deltas: 100% (4/4)
remote: Processing changes: refs: 1, done
remote: commit 5160b74: warning: subject >50 characters; use shorter first paragraph
To ssh://go/osmo-bts.git
! [remote rejected] HEAD -> refs/for/master%topic=gsm_hr_format
(I17f0b546042fa333780fd2f5c315898ab0df574c has duplicates)
error: failed to push some refs to 'ssh://go/osmo-bts.git'
A new patch with a new Change-ID is available: I453562da412fde5b928bd2b588129c58ec8e2a7e
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/30725/comment/9a61a97a_b0f8abc1
PS2, Line 1259: * carried out when the BTS model explicitly states a preference. */
this needs updating. The check is applied always.
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/30725
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I17f0b546042fa333780fd2f5c315898ab0df574c
Gerrit-Change-Number: 30725
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 20 Feb 2023 16:10:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment