Attention is currently required from: laforge.
Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306?usp=email )
Change subject: ccid: properly emit wait time ext messages ......................................................................
Patch Set 2:
(4 comments)
File ccid_common/ccid_slot_fsm.c:
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306/comment/b3dd17d6_9b6... : PS2, Line 229: resp = ccid_gen_data_block(cs, ss->seq, CCID_CMD_STATUS_TIME_EXT, 1, NULL, 0);
can we be sure that we can allocate sufficient waitign time extension messages? what a about a car […]
Then the firmware will crash and burn either way because we can't handle that slow timing and other slots won't have buffers either, but it's now a flag instead of a counter, processed once per loop, and the total amount is clamped until the card is considered mute.
File ccid_common/iso7816_fsm.h:
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306/comment/42e6f0f8_181... : PS2, Line 25: ISO7816_E_RX_SINGLE, /*!< single-byte data received on UART */
this cosmetic re-formatting or code does not belong to the patch. […]
Just unhide the build failure here and you can see that the linter prevents building this without reformatting according to the linter rules we have.
File ccid_common/iso7816_fsm.c:
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306/comment/e52236f9_1d3... : PS2, Line 227: { ISO7816_E_TX_ERR_IND, "TX_ERR_IND" },
same as above
Done
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42306/comment/7871849d_7a5... : PS2, Line 555: S(ISO7816_E_POWER_UP_IND),
and more cosmetic changes
Done