4 Mar
2023
4 Mar
'23
12:56 a.m.
Attention is currently required from: neels, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31609 )
Change subject: simplify storage of bsc_msc_data->audio_support ......................................................................
Patch Set 3:
(1 comment)
File include/osmocom/bsc/bsc_msc_data.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/31609/comment/39e5ec2d_84812a5b PS3, Line 139: for all these aspects:
oh no, here it is. […]
I really don't get it. If it's known that the maximum is 13 why use 16 here? This is confusing readers who may then try to understand why 16 is being used here. If it's a teeny detail then just fix it?
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31609
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I625cedc4bb040d649fd6e1794ba468f4c6ad6adc
Gerrit-Change-Number: 31609
Gerrit-PatchSet: 3
Gerrit-Owner: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Fri, 03 Mar 2023 13:56:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels nhofmeyr@sysmocom.de
Gerrit-MessageType: comment