Attention is currently required from: arehbein.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33652 )
Change subject: ipa: Add segmentation callback ......................................................................
Patch Set 2:
(2 comments)
File src/ipa.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/33652/comment/c2295e0a_11bb3927 PS2, Line 378: MSG_CB_IPA_PROTO_EXT_IS_SET_OFFSET can you explain those variables more? "MSGB_CB_IPA_PROTO_EXT is clear but what is "IS_SET_OFFSET"? Sounds like a predicate meaning "the offset is of type 'set'" but that doesn't make sense..
https://gerrit.osmocom.org/c/libosmo-netif/+/33652/comment/ceff8f23_ac2c1c68 PS2, Line 432: /* Below: Helper functions for addition of send_ipa functionality in later commit */ it's weird to introduce static inline helper functions in a commit thta doesn't use those.