Attention is currently required from: arehbein.

View Change

2 comments:

• File src/ipa.c:

  • Patch Set #2, Line 378: MSG_CB_IPA_PROTO_EXT_IS_SET_OFFSET

    can you explain those variables more? "MSGB_CB_IPA_PROTO_EXT is clear but what is "IS_SET_OFFSET"? Sounds like a predicate meaning "the offset is of type 'set'" but that doesn't make sense..

  • Patch Set #2, Line 432: /* Below: Helper functions for addition of send_ipa functionality in later commit */

    it's weird to introduce static inline helper functions in a commit thta doesn't use those.

To view, visit change 33652. To unsubscribe, or for help writing mail filters, visit settings.