Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by lynxis lazus. (
https://gerrit.osmocom.org/c/osmo-ggsn/+/38930?usp=email )
Change subject: gtp_new(): use talloc instead of calloc/free
......................................................................
Patch Set 3:
(1 comment)
File gtp/gsn.c:
https://gerrit.osmocom.org/c/osmo-ggsn/+/38930/comment/4a1a307b_a912134a?us… :
PS3, Line 590: static __attribute__((constructor)) void gtp_talloc_init(void)
I'd rather keep NULL by default and have a
"gtp_set_talloc_context()" API.
So that the app can pin this talloc
subtree as part of its talloc tree. Similar to what we do in other libraries.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ggsn/+/38930?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I7c4a29c4bb1ef3c7bf506e59e99b3a804cabe34b
Gerrit-Change-Number: 38930
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Mon, 25 Nov 2024 16:08:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>