Change in libosmocore[master]: ctrl: add optional port to bind command

Attention is currently required from: osmith, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30444 ) Change subject: ctrl: add optional port to bind command ...................................................................... Patch Set 5: (1 comment) File src/ctrl/control_vty.c: https://gerrit.osmocom.org/c/libosmocore/+/30444/comment/03fece6d_2300c075 PS5, Line 34: "bind A.B.C.D [<0-65535>]", in the VTY case, IMHO the idea was that the "usual" caller of vty_bind_get_port() is inside libosmovty itself: The function telnet_init_default(). Unfortunately it seems that (almost) all apps still call telnet_init_dynif(). That's a separate bug, will report it: https://osmocom.org/issues/5809 In order to avoid repeating this for thye CTRL interface, you'd also have to create a @ctrl_interface_setup_default()@ function, mark the other ones as deprecated and port all applications over from @ctrl_interface_setup_dynip()@ to that new function. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30444 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0fd87fd41fd3ac975273968d24f477daa3cd3aa9 Gerrit-Change-Number: 30444 Gerrit-PatchSet: 5 Gerrit-Owner: msuraev &lt;msuraev(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-CC: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-CC: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Attention: osmith &lt;osmith(a)sysmocom.de&gt; Gerrit-Attention: msuraev &lt;msuraev(a)sysmocom.de&gt; Gerrit-Comment-Date: Mon, 05 Dec 2022 18:27:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith &lt;osmith(a)sysmocom.de&gt; Comment-In-Reply-To: msuraev &lt;msuraev(a)sysmocom.de&gt; Gerrit-MessageType: comment