Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-upf/+/30497
to look at the new patch set (#2).
Change subject: GTP,UE addrs in osmo_sockaddr: assert( port == 0 ) ......................................................................
GTP,UE addrs in osmo_sockaddr: assert( port == 0 )
Assert that all port numbers in osmo_sockaddr parts of up_gtp_action are zero: uncover code paths that leak port numbers into the gtp_action API.
GTP and UE addresses have no port information. Port numbers in GTP,UE addresses stored in struct osmo_sockaddr should be zero, so that - to-string conversion via osmo_sockaddr_to_str_c() returns only an IP address: for nftables rules and logging. - osmo_sockaddr_cmp() matches on identical IP addresses "only", without the port numbers causing mismatches: for finding tunnels and devs.
Change-Id: If49f1e82e8cb92b7225e85a7c3b059e0f7f92fa3 --- M src/osmo-upf/upf_gtp.c M src/osmo-upf/upf_nft.c 2 files changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-upf refs/changes/97/30497/2