Attention is currently required from: csaba.sipos, laforge.
pespin has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39416?usp=email )
Change subject: nokia_site: Add object_identity, object_state and object_identity_state attributes ......................................................................
Patch Set 21:
(2 comments)
File src/osmo-bsc/bts_nokia_site.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/4a82870c_6f4e54a2?usp=... : PS21, Line 1828: get_object_identity_string(object_id_state[4]),
Wrong how? Previously it was said that the indentation has to be moved to the (, and that is what I […]
Well, it can clearly be seen in here that's not the case. See how it is not aligned to the "(" char above.
https://gerrit.osmocom.org/c/osmo-bsc/+/39416/comment/cb2bd99f_bc91a55f?usp=... : PS21, Line 1860: !FIND_ELEM(noh->data, len_data, NOKIA_EI_OBJ_STATE, &object_state, sizeof(object_state))) {
On my end they are exactly like that. […]
Sounds like you are using a different indentation config, ie 1 tab = 4 spaces vs 1 tab = 8 spaces. Have a look at your notepad++ and change it.