Attention is currently required from: falconia.
pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmocore/+/39276?usp=email )
Change subject: osmo_iofd_register: fix the case of changing fd ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1: I think the proper fix is simply to add a line after the last "if" code path check: "iofd->fd = fd;"
File src/core/osmo_io.c:
https://gerrit.osmocom.org/c/libosmocore/+/39276/comment/692a9e53_daf00168?u... : PS1, Line 756: else if (iofd->fd < 0) I think you need to leave this as is. This code block basically makes sure that iofd->fd == fd if any of them was not set (-1).