Attention is currently required from: falconia, pespin, fixeria.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33069 )
Change subject: trx TCH DL: transmit invalid speech frames instead of dummy FACCH ......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Patchset:
PS2: This patch sounds reasonable for me.
File src/osmo-bts-trx/sched_lchan_tchf.c:
https://gerrit.osmocom.org/c/osmo-bts/+/33069/comment/b36d97a9_b17b32d0 PS1, Line 500: what is the correct BTS Tx behavior for frame : * gaps in TCH/AFS
I hear you - I just don't have the needed AMR expertise to implement proper BFI transmission for AMR […]
What we could do though is to add a task in redmine and put the OS#xxxx number next to the fixme.
File src/osmo-bts-trx/sched_lchan_tchf.c:
https://gerrit.osmocom.org/c/osmo-bts/+/33069/comment/9820ac66_4a9ee9c6 PS2, Line 479: * speech frame with inverted CRC3, designed to induce a BFI Wouldn't it be more clear to call it "speech block"?