Attention is currently required from: daniel, fixeria, jolly, osmith, pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41910?usp=email )
Change subject: osmo_io: Reorder iofd_handle_segmented_read()
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/core/osmo_io.c:
https://gerrit.osmocom.org/c/libosmocore/+/41910/comment/1ae86e4b_e6994923?u... :
PS1, Line 362: vo
I'm wondering why this function is not declared static? I can only see one user and that's in the very same file? We don't need it exported and we don't need it declared in the header file, right? It's also not in the .map file so nobody outside the lib can ever have used it.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/41910?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I88683334e77901776c806dad776ef46ea20b4480
Gerrit-Change-Number: 41910
Gerrit-PatchSet: 1
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
dwillmann@sysmocom.de
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: jolly
andreas@eversberg.eu
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-Attention: osmith
osmith@sysmocom.de
Gerrit-Attention: jolly
andreas@eversberg.eu
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: daniel
dwillmann@sysmocom.de
Gerrit-Comment-Date: Thu, 22 Jan 2026 11:59:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
