Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/27129 )
Change subject: ts_102_221: Handle nested security condition data objects ......................................................................
Patch Set 2:
(3 comments)
File pySim/ts_102_221.py:
https://gerrit.osmocom.org/c/pysim/+/27129/comment/c04026c1_a6f9d08d PS1, Line 479: def from_bytes(self, binary:bytes):
Missing type hint: […]
true for this specific implementation of the abstrac method, but in general i's basically any python type, just as long as it can be json-serialized.
https://gerrit.osmocom.org/c/pysim/+/27129/comment/271bb72c_04830da9 PS1, Line 486: def to_bytes(self):
Missing type hint: […]
Done
https://gerrit.osmocom.org/c/pysim/+/27129/comment/e762d684_16b80310 PS1, Line 489: ++
Looks like you meant '+=' here? This could be done simpler: […]
Done