27 Jun
2023
27 Jun
'23
5:36 p.m.
Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/33468 )
Change subject: mgcp-client: Mark client as UP when keepalive request-interval/timeout is disabled through VTY ......................................................................
Patch Set 1:
(1 comment)
File src/libosmo-mgcp-client/mgcp_client_vty.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/33468/comment/0a8d69a7_17431012 PS1, Line 388: } /* else: wait until connect() to do first scheduling */
maybe move the whole block into a new function to de-duplicate code? but not that important
They act on different timers, it's not really duplicated code.
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/33468
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I263d23885a1a967f844033f9810b96691b8e3b30
Gerrit-Change-Number: 33468
Gerrit-PatchSet: 1
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: osmith osmith@sysmocom.de
Gerrit-Comment-Date: Tue, 27 Jun 2023 15:36:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith osmith@sysmocom.de
Gerrit-MessageType: comment