Attention is currently required from: arehbein, laforge.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/31029
)
Change subject: osmo-bsc: Fix 'apply-config-file' CTRL command
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/osmo-bsc/bsc_ctrl.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31029/comment/5a93abad_b632990f
PS2, Line 89: cmd->reply = talloc_asprintf(cmd, "Errors in neighbor
configuration");
why is it too specific? The error message is only
printed in case neighbors_check_cfg() is failing. […]
Ah I misread the function
being called, I thought the function validating the whole BTS config was being called
here, which checks several things.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/31029
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I24ae8cd7e5e0d15eab9fd04b1858072bf0bad36a
Gerrit-Change-Number: 31029
Gerrit-PatchSet: 2
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 25 Jan 2023 13:02:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment