Attention is currently required from: fixeria, laforge, neels.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/42120?usp=email )
Change subject: cp_peer: Implement local originated heartbeat procedure ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
one might have moved/extracted the header file in a separate patch, that would have saved me some c […]
I can look at splitting this in a new version of the patch, sorry for the hassle.
File src/libosmo-pfcp/pfcp_cp_peer.c:
https://gerrit.osmocom.org/c/libosmo-pfcp/+/42120/comment/6895a9d0_76b4805d?... : PS1, Line 112: unsigned int tval_rx_heartbeat_s = : osmo_tdef_get(cp_peer->ep->cfg.tdefs, OSMO_PFCP_TIMER_HEARTBEAT_RESP, OSMO_TDEF_S, -1); : o
Not critical, but it looks more logical to schedule this timer not when a response is received, but […]
No, because the Tx of Heartbeat Req is decoupled from Rx of Heartbeat Response.
You can configure: 1- How frequently to Tx HB Req 2- How long until no HB Resp triggers a timeout for the association.