Attention is currently required from: Hoernchen.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42312?usp=email
to look at the new patch set (#2).
Change subject: ccid: properly reject PC_to_RDR_{ResetParameters,SetParameters} ......................................................................
ccid: properly reject PC_to_RDR_{ResetParameters,SetParameters}
As per CCID 1.1 ch 6.2.3 a reader that does not support these commands can reject them, which we now do, instead of pretending to accept the params.
This requires https://gitlab.com/wireshark/wireshark/-/issues/20107 to be properly decoded in wireshark >= 4.4.8 .
As a bonus this fixes the error response in gen_err_resp which so far had superfluous param data attached to it.
Closes: OS#5380 Change-Id: I4d0671c160e9028097397ec47982bafbfdc24f24 --- M ccid_common/ccid_device.c 1 file changed, 9 insertions(+), 63 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/12/42312/2