Attention is currently required from: fixeria, laforge, pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34511?usp=email )
Change subject: sccplite: Support multiple MGW in MGW pool ......................................................................
Patch Set 2: Code-Review+1
(6 comments)
File src/osmo-bsc/osmo_bsc_mgcp.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/34511/comment/9dd63916_ebcb6cb2 PS1, Line 59: filled buf size
0
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/34511/comment/2dcf0ded_ce8b64f7 PS1, Line 66: if (!eol)
cosmetic: new line after the variable definitions?
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/34511/comment/c4a4508d_207fc8a6 PS1, Line 121:
with
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/34511/comment/c1a62bfd_2ad3185a PS1, Line 123: Sine
Since
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/34511/comment/e6dfe846_432bd91f PS1, Line 132: LOGL_NOTICE
maybe LOGL_DEBUG? otherwise, if there are multiple mgws in the pool, this will appear quite a lot as […]
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/34511/comment/7bd84e7f_b6c2da63 PS1, Line 170:
indentation
Done