Attention is currently required from: Timur Davydov.
pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41922?usp=email )
Change subject: core: guard TCP stats on availability of linux/tcp.h ......................................................................
Patch Set 2:
(3 comments)
File src/core/stats_tcp.c:
https://gerrit.osmocom.org/c/libosmocore/+/41922/comment/6bb76a84_51130b80?u... : PS2, Line 25: #if !defined(EMBEDDED) You can probably remove this defined(EMBEDDED) block now, since it will be covered by the ifdef HAVE_LINUX_TCP_H. You can verify it by submitting to gerrit and it should pass the CI, which also builds for EMBEDDED target.
https://gerrit.osmocom.org/c/libosmocore/+/41922/comment/427b01fd_2df34eee?u... : PS2, Line 47: #include <errno.h> Please move this up before the ifdef HAVE_LINUX_TCP_H.
https://gerrit.osmocom.org/c/libosmocore/+/41922/comment/9ff4d921_52130771?u... : PS2, Line 52: static struct osmo_tcp_stats_config s_tcp_stats_config = { This should also be inside the HAVE_LIJNUX_TCP_H block below.