Attention is currently required from: fixeria, jolly, pespin.
Hello Jenkins Builder, jolly, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40993?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed: Code-Review+1 by jolly, Code-Review+1 by pespin
Change subject: s1ap_proxy: erab_fsm_start_reg/2: check if already registered ......................................................................
s1ap_proxy: erab_fsm_start_reg/2: check if already registered
Before this patch, s1ap_proxy would spawn a new erab_fsm process with a duplicate UID and simply replace the old process in the registry. This would result in stale erab_fsm process, still linked but not present in the registry, and thus not reachable.
If there's already an E-RAB process for the given UID, simply return Pid of that existing process. The FSM will most likely reject an unexpected event, resulting in a negative verdict:
* 'reply' for duplicate E-RAB SETUP REQUEST * 'drop' for duplicate INITIAL CONTEXT SETUP REQUEST
Change-Id: I8e93492219100496fd8dc69e031310858ba9c7fb --- M src/s1ap_proxy.erl M test/s1ap_proxy_test.erl 2 files changed, 42 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-s1gw refs/changes/93/40993/2