Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/29402 )
Change subject: llc: implement LLC PDU codec based on code from osmo-sgsn.git ......................................................................
Patch Set 2:
(3 comments)
File include/osmocom/gprs/llc/llc.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-gprs-lint-52): https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/a49e0afa_7e0b76fe PS2, Line 135: #define OSMO_GPRS_LLC_PDU_F_ACK_REQ (1 << 2) /* 6.3.5.2 Acknowledgement request bit (A) */ 'Acknowledgement' may be misspelled - perhaps 'Acknowledgment'?
File src/llc/llc_pdu.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-gprs-lint-52): https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/7a83904f_718eb53f PS2, Line 277: #define check_len(len, text) \ Macros with flow control statements should be avoided
File tests/llc_pdu_codec/pdu_codec_test.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-libosmo-gprs-lint-52): https://gerrit.osmocom.org/c/libosmo-gprs/+/29402/comment/732d7332_585aed2e PS2, Line 31: static const char *testData[] = { static const char * array should probably be static const char * const