17 Nov
2025
17 Nov
'25
3:31 p.m.
Attention is currently required from: fixeria, laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/41444?usp=email )
Change subject: hnb: Allow setting Iuh tx-queue-max-length per HNB ......................................................................
Patch Set 1:
(1 comment)
File src/osmo-hnbgw/hnb.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/41444/comment/954a599e_94a1c7b9?us... : PS1, Line 219: >=
why would we permit a queue length == 0? Shouldn't it be > 0?
Allowing 0 allows temporarily blocking Tx, which can be useful eg. to test enqueuing a lot, then do bursty traffic, etc. I think it's fine allowing it.
--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/41444?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: Ibf69a5a2e6ff8d6829320efe793c6368aa542102
Gerrit-Change-Number: 41444
Gerrit-PatchSet: 1
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Mon, 17 Nov 2025 14:31:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge laforge@osmocom.org