Attention is currently required from: fixeria.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40653?usp=email )
Change subject: gprs_gmm: fix endianess of GSM48_IE_GMM_PDP_CTX_STATUS ......................................................................
Patch Set 1:
(2 comments)
File src/sgsn/gprs_gmm.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/40653/comment/083edfc6_8024d6a7?usp... : PS1, Line 1978: Create tlvp_val16be
`tlvp_val16be` is already there, did you mean `tlvp_val16le`?
Done
https://gerrit.osmocom.org/c/osmo-sgsn/+/40653/comment/735879ca_90660d5f?usp... : PS1, Line 1979: osmo_swab16(tlvp_val16be(&tp, GSM48_IE_GMM_PDP_CTX_STATUS));
I would avoid calling `tlvp_val16be()` and then swapping bytes. […]
Done