Attention is currently required from: Matan Perelman.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/gapk/+/32094 )
Change subject: fmt_rtp_amr,fmt_rtp_efr: replace damaged packets with silence ......................................................................
Patch Set 2:
(3 comments)
File src/fmt_rtp_amr.c:
https://gerrit.osmocom.org/c/gapk/+/32094/comment/f1a673de_3905b60e PS2, Line 30: static const uint8_t SILENCE[] = {0x80, 0x44, 0x00, 0x00, 0x00, 0x00, 0x00}; can you add a some comment with some spec reference as from where this hexstring comes from?
File src/fmt_rtp_efr.c:
https://gerrit.osmocom.org/c/gapk/+/32094/comment/109a4b78_82da5107 PS2, Line 33: static const uint8_t DAMAGED_PACKET[EFR_LEN] = { Same here.
https://gerrit.osmocom.org/c/gapk/+/32094/comment/b54e7661_c990f8c3 PS2, Line 70: if (!memcmp(DAMAGED_PACKET, src, EFR_LEN)) is EFR_LEN garanteed to be == src_len here?