[S] Change in gapk[master]: fmt_rtp_amr,fmt_rtp_efr: replace damaged packets with silence

Attention is currently required from: Matan Perelman. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/gapk/+/32094 ) Change subject: fmt_rtp_amr,fmt_rtp_efr: replace damaged packets with silence ...................................................................... Patch Set 2: (3 comments) File src/fmt_rtp_amr.c: https://gerrit.osmocom.org/c/gapk/+/32094/comment/f1a673de_3905b60e PS2, Line 30: static const uint8_t SILENCE[] = {0x80, 0x44, 0x00, 0x00, 0x00, 0x00, 0x00}; can you add a some comment with some spec reference as from where this hexstring comes from? File src/fmt_rtp_efr.c: https://gerrit.osmocom.org/c/gapk/+/32094/comment/109a4b78_82da5107 PS2, Line 33: static const uint8_t DAMAGED_PACKET[EFR_LEN] = { Same here. https://gerrit.osmocom.org/c/gapk/+/32094/comment/b54e7661_c990f8c3 PS2, Line 70: if (!memcmp(DAMAGED_PACKET, src, EFR_LEN)) is EFR_LEN garanteed to be == src_len here? -- To view, visit https://gerrit.osmocom.org/c/gapk/+/32094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gapk Gerrit-Branch: master Gerrit-Change-Id: I7245aa0bc0955cc8b94d5401a15e694f50498093 Gerrit-Change-Number: 32094 Gerrit-PatchSet: 2 Gerrit-Owner: Matan Perelman <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Matan Perelman <matan1008(a)gmail.com> Gerrit-Comment-Date: Tue, 28 Mar 2023 09:30:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment