Attention is currently required from: dexter.
msuraev has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/28995 )
Change subject: Add osmo_sockaddr_str_from_sockaddr2()
......................................................................
Patch Set 4:
(3 comments)
Patchset:
PS4:
I'll update existing function instead in the next version.
File src/sockaddr_str.c:
https://gerrit.osmocom.org/c/libosmocore/+/28995/comment/70fe1509_5c875e31
PS4, Line 380: {
as far as I can see the guess is the only difference.
Maybe the api doc can reflect that. […]
Ack
https://gerrit.osmocom.org/c/libosmocore/+/28995/comment/b485c13f_e36e958e
PS4, Line 385:
the guess above dereferences src, in the case where
src == NULL, the function would have crashed alr […]
Ack
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/28995
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I36f20701663c3c7eae7fedc6551da44800b325bf
Gerrit-Change-Number: 28995
Gerrit-PatchSet: 4
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 10 Aug 2022 12:44:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment