Attention is currently required from: laforge, daniel.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/31360 )
Change subject: Move include osmocom/gprs -> osmocom/gb, deprecate osmocom/gprs/
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
As I said already in the chat: this is not going to
work. […]
This is not breaking API of old applications. It would break it if we at
some point remove the dummy header left under gprs/.
While I'm in favour of keeping ABI/API compatibility, I disagree with the fact that we
can ever break it. One of such cases is by properly preparing that break over time so that
one makes sure all users are moved to a new API, by signalling to them that they should
move to the newer API and give some time until dropping it (let's say 2 years).
If that's not the intention, why are we even marking functions as DEPRECATED in first
place?
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/31360
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6e826775552766e34e4c06fe2390084596dfc286
Gerrit-Change-Number: 31360
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 20 Feb 2023 10:15:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment