Attention is currently required from: laforge.
pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40614?usp=email )
Change subject: Use xua_msg_free() everywhere to free xua_msg
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
we could probably also introduce a (rarely used in
osmocom) talloc destructor to solve the problem o […]
Yes I sometimes do that myself
when adding some types, or when some existing having no speciific desturctor suddenly need
extra logic at free time.
But since the free API already exists, the best is to use it so it can be seen quickly
where xua_msg are freed. This is specially interesting since those xua_msg actually pass
to a good amount of functions.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40614?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I1d43478a5c430e92f1bd5a0b3d3606a39f378e44
Gerrit-Change-Number: 40614
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 07 Jul 2025 20:31:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>