Attention is currently required from: fixeria.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260 )
Change subject: bsc_nat_fsm: initial conn-oriented forwarding
......................................................................
Patch Set 3:
(2 comments)
File src/osmo-bsc-nat/bsc_nat_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260/comment/ee5ae3d2_77942105
PS3, Line 74: static int sccp_sap_get_peer_addr_in(struct bsc_nat_ss7_inst *src, struct
osmo_sccp_addr **peer_addr_in,
I think both *called_addr and *calling_addr arguments
can be marked 'const'?
Done
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260/comment/8c0ab1fe_f9cba3eb
PS3, Line 78: *peer_addr_in = called_addr;
... you would need to cast pointers here and below,
but I think it's fine.
Ack
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc-nat
Gerrit-Branch: master
Gerrit-Change-Id: I3df79e4dfaa60f4fd098961ee57cda71e9773b82
Gerrit-Change-Number: 27260
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 21 Feb 2022 13:09:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment