Attention is currently required from: dexter.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/31156
)
Change subject: pcuif_proto: rename PCU_IF_SAPI_AGCH_DT to PCU_IF_SAPI_PCH_DT
......................................................................
Patch Set 2:
(1 comment)
File include/osmocom/pcu/pcuif_proto.h:
https://gerrit.osmocom.org/c/osmo-pcu/+/31156/comment/d34c3770_c85d9308
PS1, Line 42: #define PCU_IF_SAPI_PCH_DT 0x08 /* assignment on PCH (confirmed using TLLI)
*/
There are two ways to confirm an immediate assignment
via PCH. […]
Ok, so there are 2 methods. Is it really necessary to have 2 methods?
to support and maintain 2 methods?
Can we use one method or another and deprecate the other one?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/31156
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I6dfb8035134bc85a025415bd6c2f9c01987d9268
Gerrit-Change-Number: 31156
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 03 Feb 2023 13:43:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment