Attention is currently required from: jolly.
fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006?usp=email )
Change subject: s1ap_proxy: Add support for S1 HANDOVER procedure ......................................................................
Patch Set 3: Code-Review+1
(5 comments)
File include/s1gw_metrics.hrl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/441e3f91_f3738... : PS1, Line 36: handover_rsp
Let's use `handover_req_ack` here.
Done
File src/s1ap_proxy.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/8edfd8cd_e0a90... : PS1, Line 640: PATH SWITCH
These PDUs are not implemented yet, so let's keep the TODO comments for them.
Done
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/fbd13d53_ffa37... : PS1, Line 642: fetch {MME,eNB}-UE-S1AP-ID values (mandatory IEs)
this comment is not relevant here?
Done
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/2038de9a_3b570... : PS1, Line 1092: 'transportLayerAddress' = TLA_In, :
cosmetic: formatting issues
Done
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41006/comment/53d7b9f1_8d811... : PS1, Line 1113: 'transportLayerAddress' = TLA_In, :
cosmetic: formatting issues
Done