Attention is currently required from: falconia, fixeria, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/34448?usp=email )
Change subject: SMS over GSUP: implement vty config of SMSC routing
......................................................................
Patch Set 2:
(1 comment)
File include/osmocom/hlr/hlr_sms.h:
https://gerrit.osmocom.org/c/osmo-hlr/+/34448/comment/07b919da_41831ab4
PS2, Line 17: void smsc_del(struct hlr_smsc *smsc);
I think we need to differntiate between […]
Regarding "adding object to llist during alloc", I think it makes sense to do so and it's useful/simplifies code if the object is expected to be in the during its entire lifespan.
So if that's the case, having llist_add in alloc and llist_del in _free it's fine to me.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hlr/+/34448?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I1624dcd9d22b4efca965ccdd1c74f0063a94a33c
Gerrit-Change-Number: 34448
Gerrit-PatchSet: 2
Gerrit-Owner: falconia
falcon@freecalypso.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-CC: laforge
laforge@osmocom.org
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: falconia
falcon@freecalypso.org
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Tue, 19 Sep 2023 10:45:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia
falcon@freecalypso.org
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Gerrit-MessageType: comment
