laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/30135 )
Change subject: main: rotor: erase immediately after send ......................................................................
main: rotor: erase immediately after send
- improves trace diagnostic output by moving cursor back over the the rotor before a diagnostic message has a chance to be printed. there is still a race condition, but it is much better.
Change-Id: Iad7767f2a5dbbd67b0f33b9bfc2c3864ce308990 --- M firmware/apps/cardem/main.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved
diff --git a/firmware/apps/cardem/main.c b/firmware/apps/cardem/main.c index 4c337c8..6372e04 100644 --- a/firmware/apps/cardem/main.c +++ b/firmware/apps/cardem/main.c @@ -194,8 +194,8 @@ WDT_Restart(WDT); #if TRACE_LEVEL >= TRACE_LEVEL_DEBUG const char rotor[] = { '-', '\', '|', '/' }; - putchar('\b'); putchar(rotor[i++ % ARRAY_SIZE(rotor)]); + putchar('\b'); #endif check_exec_dbg_cmd(); osmo_timers_prepare();