Attention is currently required from: osmith.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/34543?usp=email )
Change subject: vty: make NCC Permitted (SI2) configurable
......................................................................
Patch Set 1:
(2 comments)
File src/osmo-bsc/bts_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/34543/comment/15311cbb_105dee79
PS1, Line 1447: no ncc-permitted
Using `no ncc-permitted` in order to permit all NCCs looks confusing, IMO. If I were to
configure this parameter as a user, I would expect `ncc-permitted all` or something like
that. The `no` variant of this command would be useful for disabling specific NCC values,
i.e. to disable NCC 2 I would do `no ncc-permitted 2`.
https://gerrit.osmocom.org/c/osmo-bsc/+/34543/comment/16c75855_15bc7536
PS1, Line 4394: struct gsm_bts *bts
const
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/34543?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I71bb855c35378f8f0598bc11a42bd274b7232a5e
Gerrit-Change-Number: 34543
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 27 Sep 2023 12:20:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment