21 Jul
2022
21 Jul
'22
2:12 a.m.
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28669 )
Change subject: trxcon: rework L1CTL socket API to support multiple clients ......................................................................
Patch Set 5:
(1 comment)
File src/host/trxcon/src/l1ctl_link.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/28669/comment/a1e7b772_6238b231 PS5, Line 223: osmo_fd_setup(&server->ofd, -1, OSMO_FD_READ, &l1ctl_server_conn_cb, server, 0);
Are you sure passing &func is correct here? look at all the osmo_fd_setup in osmocom code.
I am not getting the question. What's wrong with passing &func?
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28669
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I1cfc49f36ead6e2ba0a6110b0fb65c55412ef5e3
Gerrit-Change-Number: 28669
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Thu, 21 Jul 2022 02:12:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment