15 Jan
2024
15 Jan
'24
7:27 p.m.
Attention is currently required from: laforge, tnt.
jolly has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-e1d/+/35558?usp=email )
Change subject: Add functions to events from server to client
......................................................................
Patch Set 2:
(4 comments)
File src/e1d.h:
https://gerrit.osmocom.org/c/osmo-e1d/+/35558/comment/405fdac9_7b1c7b6c
PS1, Line 199: void *srv;
Ok, I see it used in further patches, but then I'd
use the proper type struct osmo_e1dp_server. […]
It is required for future patches
to refer to the server.
File src/osmo-e1gen.c:
https://gerrit.osmocom.org/c/osmo-e1d/+/35558/comment/e02eb6be_7b03e0f1
PS1, Line 440: void osmo_e1dp_server_event(void) {}
Why do we need this ?
the server is only
available for osmo-e1d binary, not for osmo-e1gen binary. The dummy function just ignores
the events for the non-existent protocol server.
File src/proto_clnt.c:
https://gerrit.osmocom.org/c/osmo-e1d/+/35558/comment/98295107_1f6eca29
PS1, Line 72: void (*event_cb)(enum osmo_e1dp_msg_type event, uint8_t intf, uint8_t line,
uint8_t ts, uint8_t *data, int len);
Maybe typedef some type osmo_e1dp_event_cb_t or
something ?
Done
https://gerrit.osmocom.org/c/osmo-e1d/+/35558/comment/03c6905e_5fb6dcfd
PS1, Line 85: clnt->event_cb(hdr->type, hdr->intf, hdr->line, hdr->ts,
msgb_l1(msgb) + sizeof(*hdr), msgb_l1len(msgb) - sizeof(*hdr));
Shouldn't msgb_l2() work ? And if not, having the
l2h set by earlier code would probably be good.
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/35558?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I5ee3268f8349b611c3cf3fa0572dc5eab280ab2e
Gerrit-Change-Number: 35558
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: tnt <tnt(a)246tNt.com>
Gerrit-Comment-Date: Mon, 15 Jan 2024 18:27:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: tnt <tnt(a)246tNt.com>
Gerrit-MessageType: comment